Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump x/tx #22327

Merged
merged 1 commit into from
Oct 22, 2024
Merged

build(deps): bump x/tx #22327

merged 1 commit into from
Oct 22, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 21, 2024 •
edited by coderabbitai bot
Loading

Description

Once backported it should finally fix: https://github.com/cosmos/cosmos-sdk/actions/runs/11441621784/job/31830085369 thanks to the new x/tx tag

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Updated the cosmossdk.io/x/tx dependency across multiple modules to version v1.0.0-alpha.1, potentially introducing new features and improvements.
    • Added new indirect dependencies in various modules to enhance functionality and testing capabilities.

  • Bug Fixes

    • Addressed compatibility issues by updating existing dependencies to their latest versions.

  • Chores

    • Maintained local paths for various modules to facilitate ongoing development and testing.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 21, 2024
@julienrbrt julienrbrt requested a review from a team as a code owner October 21, 2024 15:21
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request involves updates to the go.mod files across multiple modules within the cosmossdk.io project. The primary change is the version update of the cosmossdk.io/x/tx dependency from various previous versions (e.g., v0.13.3, v0.13.5) to v1.0.0-alpha.1. This update is reflected in numerous modules, along with the addition of new indirect dependencies in some cases. The overall structure of the go.mod files remains consistent, with no new modules introduced or existing modules removed.

Changes

File Path Change Summary
client/v2/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
runtime/v2/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
server/v2/cometbft/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
simapp/go.mod Updated cosmossdk.io/x/tx from v0.13.5 to v1.0.0-alpha.1; added new dependencies.
simapp/v2/go.mod Updated cosmossdk.io/x/tx from v0.13.5 to v1.0.0-alpha.1; added new indirect dependencies.
tests/go.mod Updated cosmossdk.io/x/tx from v0.13.5 to v1.0.0-alpha.1.
x/accounts/defaults/base/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/accounts/defaults/lockup/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/accounts/defaults/multisig/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/accounts/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/authz/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/bank/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/circuit/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/consensus/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/distribution/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/epochs/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/evidence/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/feegrant/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/gov/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/group/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/mint/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/nft/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/params/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependency.
x/protocolpool/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/slashing/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.
x/staking/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1; added new indirect dependencies.
x/upgrade/go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v1.0.0-alpha.1.

Possibly related PRs

Suggested labels

C:x/tx

Suggested reviewers

  • hieuvubk
  • akhilkumarpilli
  • sontrinh16
  • tac0turtle

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt added this pull request to the merge queue Oct 22, 2024
@julienrbrt julienrbrt removed the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 22, 2024
Merged via the queue into main with commit 3e65a61 Oct 22, 2024
94 of 96 checks passed
@julienrbrt julienrbrt deleted the julien/xtx branch October 22, 2024 10:33
This was referenced Oct 23, 2024
Merged
Merged
alpe added a commit that referenced this pull request Oct 25, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
f735f6d 
* main: (157 commits)
  feat(core): add ConfigMap type (#22361)
  test: migrate e2e/genutil to systemtest (#22325)
  feat(accounts): re-introduce bundler (#21562)
  feat(log): add slog-backed Logger type (#22347)
  fix(x/tx): add feePayer as signer (#22311)
  test: migrate e2e/baseapp to integration tests (#22357)
  test: add x/circuit system tests (#22331)
  test: migrate e2e/tx tests to systemtest (#22152)
  refactor(simdv2): allow non-comet server components (#22351)
  build(deps): Bump rtCamp/action-slack-notify from 2.3.1 to 2.3.2 (#22352)
  fix(server/v2): respect context cancellation in start command (#22346)
  chore(simdv2): allow overriding the --home flag (#22348)
  feat(server/v2): add SimulateWithState to AppManager (#22335)
  docs(x/accounts): improve comments (#22339)
  chore: remove unused local variables (#22340)
  test: x/accounts systemtests (#22320)
  chore(client): use command's configured output (#22334)
  perf(log): use sonic json lib  (#22233)
  build(deps): bump x/tx (#22327)
  fix(x/accounts/lockup): fix proto path (#22319)
  ...
@coderabbitai coderabbitai bot mentioned this pull request Oct 25, 2024
Merged
12 tasks
This was referenced Nov 5, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 13, 2024
Merged
Open
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
Merged
12 tasks
This was referenced Nov 28, 2024
Merged
Merged
This was referenced Dec 6, 2024
Merged
Merged
Merged
This was referenced Dec 13, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees

@kocubinski kocubinski

@tac0turtle tac0turtle

Labels
C:CLI C:server/v2 cometbft C:server/v2 Issues related to server/v2 C:x/accounts/base C:x/accounts/lockup C:x/accounts/multisig C:x/accounts C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/distribution distribution module related C:x/epochs C:x/evidence C:x/feegrant C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienrbrt @tac0turtle @sontrinh16 @kocubinski